[ckpt-rewr] Save state dict API #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
reviewed
Jun 8, 2024
bigning
reviewed
Jun 8, 2024
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
bigning
approved these changes
Jun 12, 2024
|
Please wait for the code freeze |
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
please release |
bigning
reviewed
Jun 17, 2024
mvpatel2000
pushed a commit
to mvpatel2000/composer
that referenced
this pull request
Jul 21, 2024
mvpatel2000
pushed a commit
that referenced
this pull request
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements an API for saving a state dict to disk given a sharded or full state dict:
save_state_dict_to_disk_save_sharded_state_dict_to_disk_save_full_state_dict_to_diskTests for both CPU and GPU
Also modifies testing infra for comparing DTensors and ShardedTensors, generating sharded test models