Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style #3420

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Fix style #3420

merged 1 commit into from
Jun 21, 2024
+2 −2

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Jun 21, 2024

What does this PR do?

Small docstring and style fix

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@b-chu b-chu requested review from snarayan21, j316chuck and eracah June 21, 2024 19:29
snarayan21
snarayan21 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but could you make the PR title more descriptive lol

@b-chu b-chu changed the title Fix small things Fix style Jun 21, 2024
@b-chu b-chu merged commit 1db3dbf into mosaicml:dev Jun 21, 2024
17 checks passed
mvpatel2000 pushed a commit to mvpatel2000/composer that referenced this pull request Jul 21, 2024
@b-chu @mvpatel2000
Fix small things (mosaicml#3420)
5989e99
mvpatel2000 pushed a commit that referenced this pull request Jul 21, 2024
@b-chu @mvpatel2000
Fix small things (#3420)
4e8ed2e
@b-chu b-chu deleted the fix branch November 4, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarayan21 snarayan21 snarayan21 approved these changes

@j316chuck j316chuck Awaiting requested review from j316chuck

@eracah eracah Awaiting requested review from eracah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b-chu @snarayan21