-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save load path in state and pass to mosaicmllogger #3506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a pr description if you're ready for review
Edit: you did :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! (might want to wait for daniel tho :) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a minor nit
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I'm hesitant about adding more public attributes to state. Is there something that already exists in state that we can do a before_load and after_load check on @eracah ?
Ethan and I discussed offline -- unfortunately i don' t think so because of the autoresume behavior... but open to ideas |
No idea unfortunately. I'm not blocking so feel free to merge |
What does this PR do?
Goal is to provide more visibility in the run life cycle. To do this, we can indicate when a run is resumed from checkpoint or not by displaying the load path if it was resumed from a checkpoint. Corresponding mcloud PR with
mcli describe
changes:https://github.com/databricks-mosaic/mcloud/pull/4338
What issue(s) does this change relate to?
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)