-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update moto[s3] requirement from <5,>=4.0.1 to >=4.0.1,<6 #3516
Conversation
Updates the requirements on [moto[s3]](https://github.com/getmoto/moto) to permit the latest version. - [Release notes](https://github.com/getmoto/moto/releases) - [Changelog](https://github.com/getmoto/moto/blob/master/CHANGELOG.md) - [Commits](getmoto/moto@4.0.1...5.0.12) --- updated-dependencies: - dependency-name: moto[s3] dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
@bigning triaging to you given you're most familiar here |
i searched the code base, the moto is only used here in the unit test
Since moto5.0, they changed the API from mock_s3 -> mock_aws . So i made change in setup.py to require >=5.0.1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since tests passes.
Updates the requirements on moto[s3] to permit the latest version.
Changelog
Sourced from moto[s3]'s changelog.
... (truncated)
Commits
707b272
Pre-Release: Up Version Number434c7a1
Prep release 5.0.12 (#7929)0f25f2f
CloudFormation: update_stack() - Improve UsePreviousValue behaviour (#7928)2ca9df6
CognitoIDP: ID-token is different when username=email (#7927)fbec8b6
CognitoIDP: initiate_auth with USERNAME_PASSWORD_AUTH and SMS/Software Token ...743044f
ACM: DomainValidationOptions should have SUCCESS-status (#7926)7cd2763
ConsolidateNeptune
andRDS
backends (#7925)210a2a3
Feature: Sagemaker Model Quality Job Definition (#7916)ec76952
chore: update SSM default AMI's (#7912)ac09274
Feature: Sagemaker Hyper Parameter Tuning Job (#7917)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)