Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use gloo as part of DeviceGPU's process group backend (#3509)" #3523

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

snarayan21
Copy link
Contributor

@snarayan21 snarayan21 commented Aug 6, 2024

This reverts commit cccc8a7.

Seeing errors with creating gloo PG on specific clusters. Will root cause and try to get this merged again. Props to @JackZ-db for first reporting!

What does this PR do?

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@snarayan21 snarayan21 merged commit 3aa266f into dev Aug 6, 2024
14 checks passed
@snarayan21 snarayan21 deleted the saaketh/revert_gloo branch August 6, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants