Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin pip #3524

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Unpin pip #3524

merged 2 commits into from
Aug 7, 2024

Conversation

dakinggg
Copy link
Contributor

@dakinggg dakinggg commented Aug 6, 2024

Remove pins for pip and setuptools in Dockerfile and setup.py.

Previous related issues:

  • pip was pinned because at some point in time pip 23 made installing from source not work. that seems to have been resolved, as I was able to install from source with the latest version of pip
  • EDIT: nevermind, setuptools pin is still needed to install flash attention.

Tested installing composer from source on:
2.1.2 + cpu image: try-it-cpu-2-1-2-3-V6m0Dz
2.1.2 + gpu image: try-it-gpu-2-1-2-3-BBle1N
2.2.2 + cpu image: try-it-cpu-2-2-2-3-tRu97O
2.2.2 + gpu image: try-it-gpu-2-2-2-3-sGaSyf
2.3.1 + cpu image: try-it-cpu-2-3-1-3-e5Dv41
2.3.1 + gpu image: try-it-gpu-2-3-1-3-pnHpZo

@dakinggg dakinggg requested a review from mvpatel2000 August 6, 2024 05:56
@dakinggg dakinggg marked this pull request as ready for review August 6, 2024 06:45
@dakinggg dakinggg requested a review from a team as a code owner August 6, 2024 06:45
@dakinggg dakinggg changed the title Unpin Unpin pip and setuptools Aug 6, 2024
@dakinggg dakinggg changed the title Unpin pip and setuptools Unpin pip Aug 6, 2024
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dakinggg dakinggg merged commit bd7227c into dev Aug 7, 2024
26 checks passed
@dakinggg dakinggg deleted the unpin branch August 7, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants