use s3 boto3 Adaptive retry as default retry mode #3543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3c2f089.
bigning
changed the title
bigning
changed the title
snarayan21
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
lgtm. Would like to note that we don't know if this helped solve the issue or not -- run 1b-bf16-baseline-lr-0-00042-wd-0-0008-KoQLcO also succeeded but did not use adaptive retry.
But this should be an improvement for retry behavior anyways, increasing reliability, so approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use adaptive retry as default retry mode. user reported uploading error
boto3.exceptions.S3UploadFailedError: Failed to upload /tmp/tmpn7sa44l2/26aecfcf-aa70-4385-951a-0ab28f00bf8c to data-force-one-datasets/mosaicml-internal-checkpoints/jacob/lora/atnmlp-r16-lr0.0001-mlp-ep-4-a-32-sd-17/ep1-ba193-rank0.pt: An error occurred (SlowDown) when calling the CreateMultipartUpload operation (reached max retries: 4): Please reduce your request rate.adaptive retry also introduces client-side rate limiting https://boto3.amazonaws.com/v1/documentation/api/latest/guide/retries.html,
Thanks @snarayan21 for testing:
1b-bf16-baseline-lr-0-00042-wd-0-0008-dRoKZX