Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in composer_collect_env #3566

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Fix typo in composer_collect_env #3566

merged 2 commits into from
Aug 21, 2024

Conversation

dakinggg
Copy link
Contributor

Previous PR introduced a typo into composer_collect_env that caused it to crash. This PR fixes that and adds a simple test that makes sure it runs without error.

@dakinggg dakinggg marked this pull request as ready for review August 21, 2024 01:25
@dakinggg dakinggg requested a review from mvpatel2000 August 21, 2024 01:25
mvpatel2000
mvpatel2000 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dakinggg dakinggg enabled auto-merge (squash) August 21, 2024 02:36
@dakinggg dakinggg merged commit f7707b8 into mosaicml:main Aug 21, 2024
14 checks passed
@mvpatel2000 mvpatel2000 deleted the collect-env branch August 21, 2024 03:59
@mvpatel2000 mvpatel2000 mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @mvpatel2000