Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.24.1. #3581

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Bump version to 0.24.1. #3581

merged 1 commit into from
Aug 27, 2024

Conversation

snarayan21
Copy link
Contributor

@snarayan21 snarayan21 commented Aug 27, 2024

What does this PR do?

Bumps version to 0.24.1. Doing a patch release so that we explicitly error when setting device_mesh in FSDPConfig -- this prevents users from accidentally running unintended parallelism styles (ex: FSDP when they wanted HSDP)

Dailies succeeded: https://github.com/mosaicml/composer/actions/runs/10584178277

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@snarayan21 snarayan21 merged commit 3c7fefb into main Aug 27, 2024
46 checks passed
@snarayan21 snarayan21 deleted the bump_version_v0.24.1 branch August 27, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants