Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove step in log_image for MLFlow #3601

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

Removes step in key. Mirrors #3587 with passing CI/CD

@mvpatel2000 mvpatel2000 requested a review from a team as a code owner September 4, 2024 19:18
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sick lgtm

@snarayan21
Copy link
Contributor

@mvpatel2000 @jessechancy for my own understanding, why wouldn't we want to have multiple images? since we'd presumably be logging images at some step intervals

@mvpatel2000 mvpatel2000 mentioned this pull request Sep 4, 2024
7 tasks
@mvpatel2000 mvpatel2000 merged commit 7d34d66 into mosaicml:main Sep 4, 2024
14 checks passed
@mvpatel2000 mvpatel2000 deleted the disable-step branch September 4, 2024 21:27
@mvpatel2000
Copy link
Contributor Author

@mvpatel2000 @jessechancy for my own understanding, why wouldn't we want to have multiple images? since we'd presumably be logging images at some step intervals

It's tracked using step arg to log command, name shoudl be same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants