Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tensor option for _global_exception_occured #3611

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Sep 10, 2024

What does this PR do?

Makes it able to pass MLFlowLogger to a child process with export PYTORCH_CUDA_ALLOC_CONF="expandable_segments:True"

Addresses the error:

RuntimeError: Tensors allocated with expandable_segments:True cannot be shared between processes. Consider using expandable_segments:False in data loading workers via torch.cuda.memory._set_allocator_settings('expandable_segments:False')

Run with fix: test-hf-checkpoint-fix-Vknjzg
Run without fix: test-hf-checkpoint-baseline-5ZGdqG

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@irenedea irenedea marked this pull request as ready for review September 10, 2024 19:33
@irenedea irenedea requested a review from a team as a code owner September 10, 2024 19:33
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

composer/loggers/mlflow_logger.py Outdated Show resolved Hide resolved
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
Copy link
Contributor

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@irenedea irenedea enabled auto-merge (squash) September 11, 2024 00:13
@irenedea irenedea requested review from mvpatel2000 and a team September 11, 2024 00:37
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irenedea irenedea merged commit fea4a88 into mosaicml:main Sep 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants