Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Likely with pytorch 2.4, the keys in the state dict include lots of things, and they end up in the planner.
This means that the keys that include the string "rng" in a checkpoint can be like this
The check in our code for processing rng keys is way too lenient, and tries to process the state integrations keys in this example. This PR makes the check stricter.
Manual test:
Run that fails on dev resuming:
resumption-metadata-resume-1-EzxHw6
Run that success on this PR resuming:
resumption-metadata-resume-fix-1-vhfchJ