-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raising a better warning if train or eval did not process any data. #3656
Merged
+62
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethantang-db
force-pushed
the
ethantang-db/no_batch_crash_fix
branch
from
October 17, 2024 04:50
9360e77
to
e08e52c
Compare
mihir-db
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments
ethantang-db
force-pushed
the
ethantang-db/no_batch_crash_fix
branch
2 times, most recently
from
October 17, 2024 17:08
fe69841
to
74eb09e
Compare
mvpatel2000
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with exception of small nits
ethantang-db
force-pushed
the
ethantang-db/no_batch_crash_fix
branch
from
October 17, 2024 18:37
74eb09e
to
80de437
Compare
mvpatel2000
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added warnings to the user if a train or eval epoch ended up processing no data. This can happen if somehow the data sampling ends up not feeding a process data or an empty dataset is passed in. This warning gives more visibility to the user that it has happened and that further issues or crashes can happen down the line.
Before submitting
pre-commit
on your change? (see thepre-commit
section of prerequisites)