Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't error if some batch slice has no loss generating tokens #3682

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Don't error if some batch slice has no loss generating tokens #3682

merged 1 commit into from
Oct 25, 2024

Conversation

dakinggg
Copy link
Contributor

What does this PR do?

Allow microbatches to have 0 loss generating tokens

@dakinggg dakinggg mentioned this pull request Oct 25, 2024
Merged
mvpatel2000
mvpatel2000 reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emit warning

mvpatel2000
mvpatel2000 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, too much spam from warning. I think its fine

@dakinggg dakinggg marked this pull request as ready for review October 25, 2024 00:46
@dakinggg dakinggg enabled auto-merge (squash) October 25, 2024 00:46
@dakinggg dakinggg merged commit 47d3cec into mosaicml:main Oct 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @mvpatel2000