Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotenv started failing in IE11 with version 5.0.0 #285

Closed
reginacarneiro opened this issue Mar 10, 2018 · 2 comments
Closed

dotenv started failing in IE11 with version 5.0.0 #285

reginacarneiro opened this issue Mar 10, 2018 · 2 comments

Comments

@reginacarneiro
Copy link

reginacarneiro commented Mar 10, 2018

Hello there,

I'm using dotenv in a react app to have some feature flags and it was working like a charm.
However, some users complained because they use IE11.

The problem is:

const parsed = parse(fs.readFileSync(dotenvPath, { encoding }));

It uses object shorthand syntax and IE11 doesn't support it. Could you please change it to:

const parsed = parse(fs.readFileSync(dotenvPath, { encoding: encoding }));

Or if you want I'll do a pull request for it.

@reginacarneiro
Copy link
Author

Added a pull request introducing a rollup build process which solves this issue and allows to begin the use of newer ECMAScript syntax #282.

@reginacarneiro
Copy link
Author

Just realized that dotenv is intended to only be used in a Node.js environment. Closing the issue but will leave the pull request open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant