Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue89/bridge warnings when compiling testing move module atomic bridge #92

Open
wants to merge 3 commits into
base: movement
Choose a base branch
from
Open

Issue89/bridge warnings when compiling testing move module atomic bridge #92

wants to merge 3 commits into from

Conversation

franck44
Copy link

@franck44 franck44 commented Nov 7, 2024

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Ran the move compiler on the framework package.

Key Areas to Review

The changes are minor:

  • swap attribute #[view] and doc comments
  • add attribute #[test_only] to a package used in tests only.

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@andygolay
Copy link

andygolay commented Nov 7, 2024 •
edited
Loading

I already wrote a PR for the warning fixes. #88

We can just use your PR as it also updates the .gitignore but wanted to make you aware of #88 regardless.

@andygolay andygolay mentioned this pull request Nov 7, 2024
Open
andyjsbell
andyjsbell approved these changes Nov 7, 2024
View reviewed changes
Copy link

@andyjsbell andyjsbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @franck44

@andyjsbell andyjsbell mentioned this pull request Nov 7, 2024
Closed
19 tasks
@andyjsbell andyjsbell linked an issue Nov 7, 2024 that may be closed by this pull request
[Bridge] [Warnings] when compiling/testing Move module atomic_bridge #89
Open
andygolay
andygolay approved these changes Nov 7, 2024
View reviewed changes
Copy link

@andygolay andygolay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM you just need to sign the commits.

@franck44
Copy link
Author

franck44 commented Nov 7, 2024

I already wrote a PR for the warning fixes. #88

We can just use your PR as it also updates the .gitignore but wanted to make you aware of #88 regardless.

@andygolay
Ah right. The problem is that I looked for an issue describing that warnings and could not find any.
We may need to be more disciplined and follow a standard process to identify/track this kind of issues and resolutions:

  • create an issue describing the problem
  • fix the issue (or feature etc) in a branch and then a PR

@andyjsbell andyjsbell removed the request for review from 0xmovses November 11, 2024 12:12
@andyjsbell
Copy link

@franck44 you need to have the commits signed for this to be merged

@andyjsbell andyjsbell changed the title Issue89/bridge warnings when compilingtesting move module atomic bridge Issue89/bridge warnings when compiling testing move module atomic bridge Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyjsbell andyjsbell andyjsbell approved these changes

@andygolay andygolay andygolay approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bridge] [Warnings] when compiling/testing Move module atomic_bridge
3 participants
@franck44 @andygolay @andyjsbell