-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nlohmann/json library (fixes #284) #424
Conversation
|
You are a true hero :-) |
Is there any reason why we did not specialize std::is_scalar_v in the changes within modernjson? That would have saved quite some lines in the diff? Likewise, should we consider adding support for std::isfinite and some of the other number traits? |
Your changes in this PR LGTM |
specialising is_scalar (and similar traits) would be great, but (quoting cppreference ):
|
I made the json export a bit more robust (in case a huge I also added the promised documentation. From my side, this is ready to be merged :) |
LGTM! |
Hey, I thought I'd share the following; hopefully, this will help with debugging. This Stormpy master fork fails (https://github.com/randriu/stormpy/actions/runs/6945132931/job/18893799741) on the latest version of Storm CI, possibly due to this PR. The error is inside I'm assuming this very recently started Stormpy build (https://github.com/moves-rwth/stormpy/actions/runs/6945494052/job/18894977397) will fail because of this. |
Looking at this, the problem is here: https://github.com/randriu/stormpy/blob/master/src/utility/json.cpp but I dont know where exactly. Maybe @tquatmann sees it? |
I re-applied the changes made to the old json version concerning RationalNumber support.
My changes to the main nlohmann/json release can be seen here
I briefly checked for obvious performance regressions, which does not seem to be the case.
Here some data, where I used storm-conv to parse and then export a ~38 MB JANI file from QVBS:
current main:
This branch: