Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Latest commit

 

History

History
20 lines (12 loc) · 738 Bytes

new-ui.md

File metadata and controls

20 lines (12 loc) · 738 Bytes
Raw

Adding new UI or features to Firefox Lockwise

Testing

Is it covered by XCUITests already? If not, make sure to add accessibilityIDs to all relevant view components in the form:

  • descriptiveCamelCase.button for buttons
  • descriptiveCamelCase.textField for text fields
  • etc...

Accessibility

Have you tried using VoiceOver to access your feature? Do all important and / or visible view components have accessibilityLabels?

Localization

Does your feature have strings? They should probably go in Constants.swift (more recommendations tbd on localization infrastructure for Lockbox)

User Defaults

Are you adding a new value to UserDefaults? Is there an upgrade path for users that don't have the value yet?