Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Telemetry action for settingsProvideFeedback no longer exists #1087

Closed
irrationalagent opened this issue Jul 10, 2019 · 4 comments · Fixed by #1088
Closed

Telemetry action for settingsProvideFeedback no longer exists #1087

irrationalagent opened this issue Jul 10, 2019 · 4 comments · Fixed by #1088
Labels
defect Issue describes a defect that negatively impacts use.

Comments

@irrationalagent
Copy link
Contributor

irrationalagent commented Jul 10, 2019

Once upon a time we had an action for the provide feedback button/form, so we could record telemetry for it. But I think it disappeared a long time ago.

https://github.com/mozilla-lockwise/lockwise-ios/blob/19271a021c20ef71bec22b198228cd7d143974b4/lockbox-ios/Action/SettingAction.swift

We still spec for it here

https://github.com/mozilla-lockwise/lockwise-ios/blob/master/Shared/Action/TelemetryAction.swift#L42

We seem to have had telemetry for it up until about 2018-05-31: https://sql.telemetry.mozilla.org/queries/63560/source#162668

How hard would it be to add this action back? May not be worth a whole lot of re-wiring, but it would be helpful to have.

CC @yuvalwolf

@irrationalagent irrationalagent added the defect Issue describes a defect that negatively impacts use. label Jul 10, 2019
@eliserichards
Copy link

@joeyg would this be doable?

@joeyg
Copy link
Contributor

joeyg commented Jul 10, 2019

@irrationalagent It appears that the Send Feedback link is broken. When I tap on it in settings I get taken to a webview showing mozilla.com. Is the URL here still valid? https://github.com/mozilla-lockwise/lockwise-ios/blob/master/lockbox-ios/Common/Resources/Constants.swift#L15

@irrationalagent
Copy link
Contributor Author

@joeyg pinged you in slack, maybe @yuvalwolf or @changecourse can confirm what the right URL is supposed to be

@yuvalwolf
Copy link

yuvalwolf commented Jul 10, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Issue describes a defect that negatively impacts use.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants