Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Update code base to Xcode 11 and to Swift 5 #1099

Closed
marniepw opened this issue Oct 23, 2019 · 0 comments · Fixed by #1106
Closed

Update code base to Xcode 11 and to Swift 5 #1099

marniepw opened this issue Oct 23, 2019 · 0 comments · Fixed by #1106
Labels
task Issue describes a task that needs to be completed but is not a defect or enhancement in itself.
Milestone
1.7.0

Comments

@marniepw
Copy link

marniepw commented Oct 23, 2019 •
edited
Loading

Issue

From @isabelrios "I just saw some Lockwise-iOS builds running on Buddybuild after pushing some commits 🙂 builds are red because Buddybuild updated all branches to xcode 11, I have set it back to 10.2 so hopefully builds will work again. I’m checking the XCUITests to be sure all of them are green and working as expected"

Impact

Builds are broken...

Todo

Update code base to Xcode 11 and to Swift 5.
@sandysage sandysage added the task Issue describes a task that needs to be completed but is not a defect or enhancement in itself. label Oct 25, 2019
@kaylagalway kaylagalway mentioned this issue Oct 31, 2019
Merged
@kaylagalway kaylagalway added this to the 1.7.0 milestone Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
task Issue describes a task that needs to be completed but is not a defect or enhancement in itself.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Ios 13 ui mozilla-lockwise/lockwise-ios
3 participants
@sandysage @kaylagalway @marniepw