Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Commit

Permalink
Automatically bundle core.js with all browserify bundles, and remove …
Browse files Browse the repository at this point in the history
…the specific core.js-related rules and script tags
  • Loading branch information
ianb committed Oct 19, 2016
1 parent 8171dfb commit 7da4f72
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
8 changes: 1 addition & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ chrome_static_dest := $(chrome_static_source:%=build/%)
# FIXME: obviously this is a tedious way to describe these:
chrome_external_modules := build/chrome-extension/selector-util.js build/chrome-extension/selector-snapping.js build/chrome-extension/annotate-position.js build/chrome-extension/error-utils.js build/chrome-extension/selector-ui.js build/chrome-extension/add-ids.js build/chrome-extension/extractor-worker.js build/chrome-extension/shooter-interactive-worker.js build/chrome-extension/make-static-html.js

core_js_location = $(shell node -e 'console.log(require.resolve("core-js/client/core"))')

## General transforms:
# These cover standard ways of building files given a source

Expand Down Expand Up @@ -224,10 +222,6 @@ build/server/static/img/%: build/static/img/%
@mkdir -p $(@D)
cp $< $@

build/server/static/vendor/core.js: $(core_js_location)
@mkdir -p $(@D)
cp $< $@

server_dependencies := $(shell ./bin/_bundle_dependencies server getdeps "$(server_dest)")
build/server/static/js/server-bundle.js: $(server_dependencies)
./bin/_bundle_dependencies server build ./build/server/clientglue.js
Expand Down Expand Up @@ -263,7 +257,7 @@ build/server/build-time.js: homepage $(server_dest) $(shared_server_dest) $(sass
@mkdir -p $(@D)
./bin/_write_build_time > build/server/build-time.js

server: npm build/server/build-time.js build/server/static/js/server-bundle.js build/server/static/js/homepage-bundle.js build/server/static/js/admin-bundle.js build/server/static/js/shotindex-bundle.js build/server/static/js/leave-bundle.js build/server/static/js/creating-bundle.js build/server/static/vendor/core.js
server: npm build/server/build-time.js build/server/static/js/server-bundle.js build/server/static/js/homepage-bundle.js build/server/static/js/admin-bundle.js build/server/static/js/shotindex-bundle.js build/server/static/js/leave-bundle.js build/server/static/js/creating-bundle.js

## Homepage related rules:

Expand Down
2 changes: 1 addition & 1 deletion bin/_bundle_dependencies
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ build() {
mkdir -p "$(dirname "$(depfile)")"
browserify --list -e "$@" | sed "s!$(pwd)/!!g" | grep -v build-time > "$(depfile)"
browserify -o "build/server/static/js/${project_name}-bundle.js" \
-e "$@"
-e "$@" -r core-js/client/core
}

case "$cmd" in
Expand Down
1 change: 0 additions & 1 deletion server/src/views/frame.js
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,6 @@ class Head extends React.Component {
let js = [
<script src="//www.google-analytics.com/analytics.js" async key="gaScript" />,
<script src="/ga-activation-hashed.js" key="gaActivation" />,
<script src={ this.props.staticLink("vendor/core.js") } key="core-js-js" />,
<script src={ this.props.staticLink("js/server-bundle.js") } key="server-bundle-js" />,
];

Expand Down

0 comments on commit 7da4f72

Please sign in to comment.