use a moz-extension src for the overlay iframes

mozilla-services · Apr 12, 2017 · da19766 · da19766
1 parent 7d8c5d8
commit da19766
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 0 deletions.
diff --git a/addon/webextension/blank.html b/addon/webextension/blank.html
@@ -0,0 +1 @@
+<html></html>
diff --git a/addon/webextension/manifest.json.template b/addon/webextension/manifest.json.template
@@ -56,6 +56,7 @@
     }
   ],
   "web_accessible_resources": [
+    "blank.html",
     "icons/cancel.svg",
     "icons/download.svg",
     "icons/icon-256.png",

diff --git a/addon/webextension/onboarding/slides.js b/addon/webextension/onboarding/slides.js
@@ -22,6 +22,7 @@ this.slides = (function () {
       callbacks = addCallbacks;
       // FIXME: a lot of this iframe logic is in ui.js; maybe move to util.js
       iframe = document.createElement("iframe");
+      iframe.src = browser.extension.getURL("blank.html");
       iframe.id = "firefox-screenshots-onboarding-iframe";
       iframe.style.zIndex = "99999999999";
       iframe.style.border = "none";

diff --git a/addon/webextension/selector/ui.js b/addon/webextension/selector/ui.js
@@ -82,6 +82,7 @@ this.ui = (function () { // eslint-disable-line no-unused-vars
       return new Promise((resolve, reject) => {
         if (! this.element) {
           this.element = document.createElement("iframe");
+          this.element.src = browser.extension.getURL("blank.html");
           this.element.id = "firefox-screenshots-selection-iframe";
           this.element.style.display = "none";
           this.element.style.zIndex = "99999999999";
@@ -207,6 +208,7 @@ this.ui = (function () { // eslint-disable-line no-unused-vars
       return new Promise((resolve, reject) => {
         if (! this.element) {
           this.element = document.createElement("iframe");
+          this.element.src = browser.extension.getURL("blank.html");
           this.element.id = "firefox-screenshots-preselection-iframe";
           this.element.style.zIndex = "99999999999";
           this.element.style.border = "none";