Actually fix #2796, disable all active A/B tests

* Document tests are finished * Remove code referring to autoOpenSharePanel * Remove code and styles referring to styleMyShotsButton * Put all old tests in deprecatedTests
mozilla-services · May 4, 2017 · ddcb7fc · ddcb7fc
1 parent 5557426
commit ddcb7fc
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 25 deletions.
diff --git a/addon/webextension/selector/uicontrol.js b/addon/webextension/selector/uicontrol.js
@@ -815,10 +815,6 @@ this.uicontrol = (function() {
       return;
     }
     addHandlers();
-    // FIXME: self.options is gone
-    if (self.options && self.options.styleMyShotsButton) {
-      ui.iframe.addClassName = `styleMyShotsButton-${self.options.styleMyShotsButton.value}`;
-    }
     if (shouldOnboard) {
       setState("onboarding");
     } else {

diff --git a/docs/METRICS.md b/docs/METRICS.md
@@ -75,21 +75,21 @@ Event label: exactly what control invoked the action, such as toolbar-button.  T
 
 #### A/B tests
 
-##### Highlight shot button
+##### (finished) Highlight shot button
 
 As described in [#2081](https://github.com/mozilla-services/screenshots/issues/2081) we are putting a badge on the button of some users.  The test is named `highlightButtonOnInstall`.
 
 The dimension `cd3` will be `control` (no badge) or `badge` (10% of population).
 
 If the badge is shown we send the event `addon/ab-highlight-button-shown` – this is marked as a non-interactive event.
 
-##### Adjust My Shots button display
+##### (finished) Adjust My Shots button display
 
 As described in [#2082](https://github.com/mozilla-services/screenshots/issues/2082) we are changing how the My Shots button is displayed.  The test is named `styleMyShotsButton`.
 
 The dimension `cd4` will be `control` (normal styling) or something else Yet To Be Determined.
 
-##### Auto-open share panel
+##### (finished) Auto-open share panel
 
 As described in [#2079](https://github.com/mozilla-services/screenshots/issues/2079) we auto-open the share panel for a set of users.  The test is named `autoOpenSharePanel`.
 

diff --git a/server/src/ab-tests.js b/server/src/ab-tests.js
@@ -49,7 +49,7 @@ let allTests = {
 
 // Any test names listed here will get removed from the A/B tests.  Tests should
 // be moved here once we are uninterested in any future data from the test:
-let deprecatedTests = [];
+let deprecatedTests = ['highlightButtonOnInstall', 'styleMyShotsButton', 'autoOpenSharePanel'];
 
 class Test {
   constructor(options) {

diff --git a/server/src/share-buttons.js b/server/src/share-buttons.js
@@ -5,9 +5,6 @@ exports.ShareButton = class ShareButton extends React.Component {
   constructor(props) {
     super(props);
     let display = false;
-    if (props.abTests.autoOpenSharePanel && props.abTests.autoOpenSharePanel.value === "autoopen") {
-      display = props.isOwner && Date.now() - props.shot.createdDate < 30000;
-    }
     this.state = {display};
   }
 

diff --git a/static/css/inline-selection.scss b/static/css/inline-selection.scss
@@ -398,20 +398,6 @@ $very-light-grey: #ededed;
   @include flex-container(row, center, center);
 }
 
-/* styleMyShotsButton test: */
-
-.styleMyShotsButton-bright .myshots-button {
-  color: #fff;
-  background: $link-blue;
-}
-
-.styleMyShotsButton-bright .myshots-text-pre,
-.styleMyShotsButton-bright .myshots-text-post {
-  filter: brightness(20);
-}
-
-/* end styleMyShotsButton test */
-
 @keyframes pulse {
   0% {
     transform: scale(1);