Fix #2410, use 'Screenshot: title' for the <title> of shot pages

mozilla-services · Aug 1, 2017 · ed2b2c2 · ed2b2c2
1 parent cde91d3
commit ed2b2c2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/locales/en-US/server.ftl b/locales/en-US/server.ftl
@@ -1,5 +1,5 @@
 // Localization for Server-side strings of Firefox Screenshots
-// 
+//
 // Please don't localize Firefox, Firefox Screenshots, or Screenshots
 
 
@@ -81,6 +81,8 @@ notFoundPageDescription = Page not found.
 
 [[ Shot page ]]
 
+// This is the HTML title tag of the page
+shotPageTitle = Screenshot: { $originalTitle }
 shotPageAlertErrorUpdatingExpirationTime = Error saving expiration
 shotPageAlertErrorDeletingShot = Error deleting shot
 shotPageAlertErrorUpdatingTitle = Error saving title
@@ -238,4 +240,3 @@ metricsPageHeader = Metrics
 metricsPageGeneratedDateTime = Generated at: { $created }
 // Note { $time } is a placeholder for a number of milliseconds, like '100'
 metricsPageDatabaseQueryTime = (database time: { $time }ms)
-
diff --git a/server/src/pages/shot/model.js b/server/src/pages/shot/model.js
@@ -13,8 +13,9 @@ exports.createModel = function(req) {
   if (req.shot.favicon) {
     req.shot.favicon = createProxyUrl(req, req.shot.favicon);
   }
+  let title = req.getText("shotPageTitle", {originalTitle: req.shot.title});
   let serverPayload = {
-    title: req.shot.title,
+    title,
     staticLink: req.staticLink,
     backend: req.backend,
     shot: req.shot,