Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Stop toggling button state onActivated #2800

Closed
jaredhirsch opened this issue May 3, 2017 · 0 comments · Fixed by #2814
Closed

Stop toggling button state onActivated #2800

jaredhirsch opened this issue May 3, 2017 · 0 comments · Fixed by #2814
Assignees
@jaredhirsch
Milestone
Sprint 54.6

Comments

@jaredhirsch
Copy link
Member

According to kmag, webextension buttons have per-tab state, so setting the button enabled or disabled on update should be enough. Updating the icon on activated may be causing performance issues.
@jaredhirsch jaredhirsch self-assigned this May 3, 2017
@ghost ghost added this to the Sprint 54.6 milestone May 4, 2017
@jaredhirsch jaredhirsch mentioned this issue May 5, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jaredhirsch jaredhirsch

Labels
None yet
Projects
None yet
Milestone
Sprint 54.6
Development

Successfully merging a pull request may close this issue.

Perf fixes mozilla-services/screenshots
1 participant
@jaredhirsch