This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
When initing l10n, cache contents of FTL files, not user locale (#3170) #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredhirsch
force-pushed
the
3170-l10n-cleanup
branch
2 times, most recently
from
7990248
to
e91e76e
Compare
* Also, bail if locales aren't found or can't be loaded.
jaredhirsch
force-pushed
the
3170-l10n-cleanup
branch
from
e91e76e
to
bde63c5
Compare
ianb
approved these changes
Jul 25, 2017
| }); | ||
| }).catch(err => { | ||
| mozlog.info("l10n-error", {msg: "Error loading FTL files", description: err}); | ||
| l10n.init().then(() => { |
There was a problem hiding this comment.
This (l10n.init()) is weird in a handler, but without #2208 I guess it's the best we got.
server/src/l10n.js
Outdated
| if (inited) { | ||
| return Promise.resolve(); | ||
| } | ||
| inited = true; | ||
| exports.userLangs = userLocales; |
There was a problem hiding this comment.
there's a possibility of a dogpile here, if multiple requests come in early. It should sort itself out, but I think it would be safer to do:
let initPromise;
exports.init = function() {
if (initPromise) {
return initPromise;
}
initPromise = globby(...);
return initPromise;
};
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3170 for me locally