This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fix npm audit fail issue 4803 #4948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-k
force-pushed
the
fix-npm-audit-fail-issue-4803
branch
7 times, most recently
from
287171f
to
b18f50a
Compare
I'll take free help + irc spam any time you have spare cycles ^_^ |
jaredhirsch
suggested changes
Sep 26, 2018
|
The npm version required is a problem locally until #4804 is fixed. (Or we could document that as a requirement for the project). |
added 7 commits
September 26, 2018 16:27
to make it valid JSON
istanbul middleware
https://www.npmjs.com/advisories/681 at paths: jpm > firefox-profile > adm-zip web-ext > firefox-profile > adm-zip These 1) run from build tools that already have access to local the local filesystem and 2) do not take input files outside the repo
g-k
force-pushed
the
fix-npm-audit-fail-issue-4803
branch
from
0a1444d
to
e4ffef7
Compare
|
OK made some changes:
Haven't tested this PR on OSX (have tested audit-filer), but try running: |
jaredhirsch
approved these changes
Sep 27, 2018
There was a problem hiding this comment.
Nice work! I'm not sure I'm qualified to review all the platform detection code in the shell script, but it looks fine at a glance, and does work on mac. I also tried removing one of the .nsprc entries, and the linter correctly failed on the missing advisory. Merging.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming no new insecure deps, this should fix #4803 (for CI at least).
OK this is finally ready for review. Sorry about all the spam in #screenshots on irc.