Define button color #5000
Define button color #5000
Conversation
In Linux desktop with dark theme, default button text color is white or light gray. If button background is set to a light color, button text are not visible. So button text color and background color must both be defined.
|
@guoyunhe Thanks for the pull request. What linux distro and window manager are you using? |
|
@6a68 openSUSE Tumbleweed + KDE 5.14.0 with Breeze Dark theme. |
There was a problem hiding this comment.
Thanks for the pull request. I was curious about this issue, and a little digging turned up a long, sad history of Firefox applying system styles to websites, with odd results on Linux for certain dark themes--particularly themes that don't provide both light and dark options, but just default to dark. (https://bugzilla.mozilla.org/show_bug.cgi?id=70315 seems to be the original bug, in case anyone's interested in exploring.)
But, back to this PR. I'm hesitant to override the ButtonText system color with black, but I can't come up with a good reason not to. Windows high contrast mode forces the button label to white, so specifying black for the text color doesn't cause problems there. Moreover, we do already style the button pretty extensively. If this turns out to break the button labels for users of different linux themes, I'll probably have to revert the change. For now, I'll merge it and we'll see how it goes 👍
In Linux desktop with dark theme, default button text color is white or light gray. If button background is set to a light color, button text are not visible. So button text color and background color must both be defined.
Before:
After: