Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

[Hold] Fixes #5172 - Hide edit tool icon in Microsoft Edge #5175

Merged

Conversation

punamdahiya
Copy link
Contributor

No description provided.

@punamdahiya punamdahiya changed the title Fixes #5172 - Hide edit tool icon in Microsoft Edge [Hold] Fixes #5172 - Hide edit tool icon in Microsoft Edge Nov 14, 2018
Copy link
Member

@jaredhirsch jaredhirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay as a provisional fix, but this UA sniffing approach is not an acceptable long-term practice. If we're going to maintain this server long-term, we should be using Modernizr to detect the specific canvas APIs not (yet) supported in various browsers, and polyfill them appropriately. I'll file a bug to discuss on monday.

@jaredhirsch jaredhirsch merged commit b785432 into mozilla-services:master Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants