From de8d239fb6ddcd2f2293dfc1ce5dabbac9e8a0af Mon Sep 17 00:00:00 2001 From: Ankita Saxena Date: Sun, 27 Aug 2017 16:05:46 +0530 Subject: [PATCH 1/4] shifted buttons from right to left --- static/css/inline-selection.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/static/css/inline-selection.scss b/static/css/inline-selection.scss index 3ddcd5120c..5c7576e767 100644 --- a/static/css/inline-selection.scss +++ b/static/css/inline-selection.scss @@ -209,7 +209,7 @@ $very-light-grey: #ededed; @include flex-container(row, center, center); bottom: -55px; position: absolute; - right: 5px; + left: 5px; z-index: 6; .bottom-selection & { From bbb07eed3d13962f6b63a826d931fd6b47754fa1 Mon Sep 17 00:00:00 2001 From: Ankita Saxena Date: Sun, 27 Aug 2017 16:08:12 +0530 Subject: [PATCH 2/4] swapped text and image on save button --- static/css/inline-selection.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/static/css/inline-selection.scss b/static/css/inline-selection.scss index 5c7576e767..ad000912af 100644 --- a/static/css/inline-selection.scss +++ b/static/css/inline-selection.scss @@ -238,13 +238,13 @@ $very-light-grey: #ededed; @extend .button; @extend .primary; background-image: url("MOZ_EXTENSION/icons/cloud.svg"); - background-position: 8px center; + background-position: 55px center; background-repeat: no-repeat; background-size: 20px 18px; font-size: 18px; margin: 5px; min-width: 80px; - padding-left: 34px; + padding-right: 34px; } .highlight-button-download { From a96fa66d339d55795995f6c362e5e923d2bcd0d9 Mon Sep 17 00:00:00 2001 From: Ankita Saxena Date: Tue, 29 Aug 2017 22:44:06 +0530 Subject: [PATCH 3/4] fixed the buttons --- static/css/inline-selection.scss | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/static/css/inline-selection.scss b/static/css/inline-selection.scss index ad000912af..b70ecce7e0 100644 --- a/static/css/inline-selection.scss +++ b/static/css/inline-selection.scss @@ -209,7 +209,12 @@ $very-light-grey: #ededed; @include flex-container(row, center, center); bottom: -55px; position: absolute; - left: 5px; + html[dir="rtl"] & { + left: 5px; + } + html[dir="ltr"] & { + right: 5px; + } z-index: 6; .bottom-selection & { @@ -238,13 +243,23 @@ $very-light-grey: #ededed; @extend .button; @extend .primary; background-image: url("MOZ_EXTENSION/icons/cloud.svg"); - background-position: 55px center; + html[dir="ltr"] & { + background-position: 8px center; + } + html[dir="rtl"] & { + background-position: 65px center; + } background-repeat: no-repeat; background-size: 20px 18px; font-size: 18px; margin: 5px; min-width: 80px; - padding-right: 34px; + html[dir="ltr"] & { + padding-left: 34px; + } + html[dir="rtl"] & { + padding-right: 34px; + } } .highlight-button-download { From d23a76178707742bb5ea9338e2ab0a0b60da076b Mon Sep 17 00:00:00 2001 From: Ankita Saxena Date: Tue, 29 Aug 2017 23:29:41 +0530 Subject: [PATCH 4/4] adjusted position of image --- static/css/inline-selection.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/static/css/inline-selection.scss b/static/css/inline-selection.scss index b70ecce7e0..c556a85947 100644 --- a/static/css/inline-selection.scss +++ b/static/css/inline-selection.scss @@ -258,7 +258,7 @@ $very-light-grey: #ededed; padding-left: 34px; } html[dir="rtl"] & { - padding-right: 34px; + padding-right: 40px; } }