Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including .css files with @import is non-standard behaviour #12674

Closed
willdurand opened this issue Nov 16, 2018 · 3 comments · Fixed by mozilla/addons-frontend#7004
Closed

Including .css files with @import is non-standard behaviour #12674

willdurand opened this issue Nov 16, 2018 · 3 comments · Fixed by mozilla/addons-frontend#7004
Assignees
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Milestone

Comments

@willdurand
Copy link
Member

Let's fix this warning:

Including .css files with @import is non-standard behaviour which will be removed in future versions of LibSass.
Use a custom importer to maintain this behaviour. Check your implementations documentation on how to create a custom importer.

It happens when running:

  • yarn storybook
  • yarn build
@HMarzban
Copy link

hi @willdurand, According to this issue it's a "bug" from node-sass.
currently, we use node-sass version 4.9.1, and base on this comment we have to wait for the new version which is 4.11.0.

@willdurand
Copy link
Member Author

Hi @HosseinMarzban, yep I was about to comment too. The message was not a bug but it has been reverted because of the community's reaction: sass/libsass#2684.

@HMarzban
Copy link

Exactly, I read it all, so we have to wait until the new version comes up, then update the package.

@willdurand willdurand added this to the 2018.11.29 milestone Nov 21, 2018
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants