Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: A reviewer cannot reply to a soft-blocked version #15251

Closed
1 task done
wagnerand opened this issue Dec 17, 2024 · 3 comments · Fixed by mozilla/addons-server#22952
Closed
1 task done

[Bug]: A reviewer cannot reply to a soft-blocked version #15251

wagnerand opened this issue Dec 17, 2024 · 3 comments · Fixed by mozilla/addons-server#22952

Comments

@wagnerand
Copy link
Member

wagnerand commented Dec 17, 2024

What happened?

For an add-on, several versions were soft-blocked.
The developer replied with a question, but reviewers cannot reply, as the "Versions" select in the Review Tools page is empty.

What did you expect to happen?

A reviewer should be able to reply to soft-blocked versions.

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

@ioanarusiczki
Copy link

So while versions are blocked/restricted but the add-on is not entirely force-disabled

I could reply for
a restricted https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/634997
a blocked https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/634998
an addon with multiple versions, one restricted, one blocked, one approved
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/634996

@ioanarusiczki
Copy link

For unlisted versions I could send reviewer replies and the un-reject multiple versions is empty - no versions available there to be selected.

https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/635030

As a reviewer (I am with an admin account) I can send replies while add-on is force-disabled but a developer cannot reply.
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635031

Another test a theme , version blocked then softened.

https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/635035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants