Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage reports broken due to nightly bustage in a dependency #3851

Closed
rfk opened this issue Feb 2, 2021 · 2 comments
Closed

Coverage reports broken due to nightly bustage in a dependency #3851

rfk opened this issue Feb 2, 2021 · 2 comments

Comments

@rfk
Copy link
Contributor

rfk commented Feb 2, 2021

Our coverage reports use cargo-tarpaulin grcov, which means they have to run on Nightly Rust. Nightly Rust recently stabilized the ::BITS associated constant on integer types. One of our downstream dependencies had a conflicting trait implementation that also defined a ::BITS constant, so now that dependency fails to build on Nightly Rust and our coverage reports don't run.

I don't think there's much we can do here apart from wait for an updated release of lexical-core, but I wanted to put it on file for completeness.

┆Issue is synchronized with this Jira Task
┆Sprint: Backlog

@HTGAzureX1212
Copy link

HTGAzureX1212 commented Feb 2, 2021

It also affected my project so I just cloned the repository (the lexical-core repository), made the fixes and using the [patch] section in Cargo.toml to use the lexical-core on my computer with my fix instead of the one on crates.io which is broken.

@rfk
Copy link
Contributor Author

rfk commented Feb 3, 2021

Thanks @HTG-YT, and thanks for your work to track down the underlying cause here in the linked bugs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants