switching to new classnames - #1321 #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't show up on the staged PR, so for design review see this screenshot:
|
|
Looks good as long as that is reflected on all the primary pages, not just Participate. |
alanmoo
approved these changes
Apr 12, 2018
|
So which pages need to be compared? I see a few more on "Initiatives" but I think that's it. |
kristinashu
approved these changes
Apr 12, 2018
|
@alanmoo probably all the wagtail pages: Initiatives, Participate, People, About Us, (News looks ok I think). Not sure what's happening with all the Opportunity and Campaign pages. |
|
Opportunity and Campaign will likely need updates in the CMS editor, not in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #1321