diff --git a/neqo-bin/src/udp.rs b/neqo-bin/src/udp.rs index 94488032d7..148ff43175 100644 --- a/neqo-bin/src/udp.rs +++ b/neqo-bin/src/udp.rs @@ -9,6 +9,7 @@ use std::{io, net::SocketAddr}; use neqo_common::Datagram; /// Ideally this would live in [`neqo-udp`]. [`neqo-udp`] is used in Firefox. +/// /// Firefox uses `cargo vet`. [`tokio`] the dependency of [`neqo-udp`] is not /// audited as `safe-to-deploy`. `cargo vet` will require `safe-to-deploy` for /// [`tokio`] even when behind a feature flag. diff --git a/neqo-crypto/src/replay.rs b/neqo-crypto/src/replay.rs index 2f4613e525..dcd5775f57 100644 --- a/neqo-crypto/src/replay.rs +++ b/neqo-crypto/src/replay.rs @@ -40,6 +40,7 @@ scoped_ptr!( ); /// `AntiReplay` is used by servers when processing 0-RTT handshakes. +/// /// It limits the exposure of servers to replay attack by rejecting 0-RTT /// if it appears to be a replay. There is a false-positive rate that can be /// managed by tuning the parameters used to create the context. diff --git a/neqo-transport/src/path.rs b/neqo-transport/src/path.rs index 9523a392b6..22b677a239 100644 --- a/neqo-transport/src/path.rs +++ b/neqo-transport/src/path.rs @@ -452,10 +452,10 @@ impl Paths { // make a new RTT esimate and interrogate that. // That is more expensive, but it should be rare and breaking encapsulation // is worse, especially as this is only used in tests. - self.primary() - .map_or(RttEstimate::default().estimate(), |p| { - p.borrow().rtt().estimate() - }) + self.primary().map_or_else( + || RttEstimate::default().estimate(), + |p| p.borrow().rtt().estimate(), + ) } pub fn set_qlog(&mut self, qlog: NeqoQlog) { diff --git a/test-fixture/src/sim/mod.rs b/test-fixture/src/sim/mod.rs index 9cf43b4b67..17e7f2b465 100644 --- a/test-fixture/src/sim/mod.rs +++ b/test-fixture/src/sim/mod.rs @@ -42,8 +42,10 @@ macro_rules! boxed { } /// Create a simulation test case. This takes either two or three arguments. +/// /// The two argument form takes a bare name (`ident`), a comma, and an array of /// items that implement `Node`. +/// /// The three argument form adds a setup block that can be used to construct a /// complex value that is then shared between all nodes. The values in the /// three-argument form have to be closures (or functions) that accept a reference