From aca1352b6bf93d8fe2cf0f627dc2fdf83a0bf95d Mon Sep 17 00:00:00 2001 From: Max Inden Date: Mon, 8 Apr 2024 07:01:58 +0200 Subject: [PATCH] fix(bin/bench): rename 1-conn/10_000-1b-seq-resp to parallel (#1796) The benchmark is using the default concurrency factor. By default `neqo-client` runs up to `100` requests in parallel. https://github.com/mozilla/neqo/blob/5dfe106669ccb695187511305c21b8e8a8775e91/neqo-bin/src/client/mod.rs#L151-L153 Thus the benchmark name is wrong, i.e. the requests are run in parallel and not sequentially. --- neqo-bin/benches/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/neqo-bin/benches/main.rs b/neqo-bin/benches/main.rs index 3afcc5d127..59927ebe0c 100644 --- a/neqo-bin/benches/main.rs +++ b/neqo-bin/benches/main.rs @@ -33,7 +33,7 @@ fn transfer(c: &mut Criterion) { sample_size: Some(10), }, Benchmark { - name: "1-conn/10_000-1b-seq-resp (aka. RPS)".to_string(), + name: "1-conn/10_000-parallel-1b-resp (aka. RPS)".to_string(), requests: vec![1; 10_000], sample_size: None, },