Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Preferences to make them properly async #4459

Closed
Snuffleupagus opened this issue Mar 14, 2014 · 1 comment · Fixed by #4482
Closed

Rewrite Preferences to make them properly async #4459

Snuffleupagus opened this issue Mar 14, 2014 · 1 comment · Fixed by #4482
Assignees
Labels

Comments

@Snuffleupagus
Copy link
Collaborator

I've recently looked at the way that I implemented Preferences, and concluded that there is definitely room for improvement.
Particularly, they are not properly async, which is likely to cause issues at some point. For example, I think that Preferences.get really should return a Promise instead.

/cc @brendandahl: Before I begin rewriting this, I'd appreciate some feedback regarding how you would like Preferences to work.

@Snuffleupagus Snuffleupagus self-assigned this Mar 14, 2014
@brendandahl
Copy link
Contributor

Having get and set return promises would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants