Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor files to remove circular module dependecies hacks #6777

Closed
3 tasks done
yurydelendik opened this issue Dec 18, 2015 · 1 comment
Closed
3 tasks done

Refactor files to remove circular module dependecies hacks #6777

yurydelendik opened this issue Dec 18, 2015 · 1 comment
Labels
core

Comments

@yurydelendik
Copy link
Contributor

yurydelendik commented Dec 18, 2015 •
edited
Loading

Some ideas:

  • colorspace.js needs image.js
    • make resize as a service, and let image register this service at colorspace or some other places?
  • font_renderer.js needs fonts.js
    • we need to split fonts.js file into smaller modules, e.g. move EncodingsCFFParser into separate file
  • stream.js needs parser.js and colorspace.js
    • refactor Ascii85Stream to not use Lexer
    • refactor isNativelySupported and isNativelyDecodable to use some service to parse colorspace ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yurydelendik @timvandermeij