Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate issue6961 test due to its frequent test failures #7112

Closed
yurydelendik opened this issue Mar 25, 2016 · 4 comments · Fixed by #12943
Closed

Investigate issue6961 test due to its frequent test failures #7112

yurydelendik opened this issue Mar 25, 2016 · 4 comments · Fixed by #12943
Labels

Comments

@yurydelendik
Copy link
Contributor Author

Test is disabled to save efforts/resources on other pull requests.

@timvandermeij
Copy link
Contributor

Yes, it seems to fail quite often, so it's good to disable it for now. I wonder what's wrong with it as it loads quite fast for me locally. This file came from 07e1ad4. If we can find out what's wrong with it, I might be able to provide a new file generated by the same tool, as I provided the current file too.

@Snuffleupagus
Copy link
Collaborator

Should we attempt to re-enable this test-case now, or should we simply close this as WONTFIX?

@timvandermeij
Copy link
Contributor

I'd say we can try enabling it since many fixes were made since this issue was originally opened. If we run the test suite with it a couple of times and it passes, we're safe to re-enable it. If not, I'm not sure what is wrong with it and we can close this issue. It might be that all the test framework fixes and performance fixes have actually fixed the problems we encountered before in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants