Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent test failures after updating to Firefox 50 #7542

Closed
Snuffleupagus opened this issue Aug 15, 2016 · 5 comments
Closed

Intermittent test failures after updating to Firefox 50 #7542

Snuffleupagus opened this issue Aug 15, 2016 · 5 comments

Comments

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Aug 15, 2016

As can be seen in #3891 (comment) and below, Firefox 50 causes intermittent test failures both when run locally and on the bots.
Especially the tracemonkey-fbf test is problematic, since it prevents makeref from completing successfully.

This appears to be a regression from bug 1289380, according to #3891 (comment):

As mentioned on IRC, running mozregression (on Windows) gave me the following range: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=950a962b75eae61cb9f0c5638b6b362427f7ebe6&tochange=fc5b4f286716bf47199435415f945695c1c20d0b.
Given the commit message and the actual code this seems like a fairly reasonable regression range, but I'd be great if someone else could confirm that it's accurate.

/cc @brendandahl, @yurydelendik

@Snuffleupagus
Copy link
Collaborator Author

What we need to do here is:

  • Confirm that the regression range found above is correct.
  • Create a standalone, and preferably reduced, test-case in order to report the issue upstream.

@Snuffleupagus
Copy link
Collaborator Author

Snuffleupagus commented Aug 20, 2016

On a hunch I re-tested PR #7330, rebased to master, locally on Windows. That PR tries to address a Firefox specific intermittent issue, as outlined in #7188 (comment).

Interestingly enough, locally that patch actually prevents all the intermittent test failures that I'm seeing on the current master!
Given that PR #7330 fixes an actual rendering issue, and that it seems to also help with this issue, I'd really like to get that landed to see if it helps on the bots as well.

/cc @brendandahl, @yurydelendik

@timvandermeij
Copy link
Contributor

The patch is merged, so the intermittents should be resolved. I guess you want to keep this open for reporting it upstream?

@Snuffleupagus
Copy link
Collaborator Author

The patch is merged, so the intermittents should be resolved.

Most of them are, but we still need https://bugzilla.mozilla.org/show_bug.cgi?id=1292870 as well.

@timvandermeij
Copy link
Contributor

The upstream bug has been fixed and uplifted as well a few days ago, and after making new reference images today the tests do not fail intermittently anymore, so let's close this as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants