Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y-axis is mislabeled / data is misleading #347

Closed
mreid-moz opened this issue Feb 28, 2018 · 8 comments
Closed

Y-axis is mislabeled / data is misleading #347

mreid-moz opened this issue Feb 28, 2018 · 8 comments

Comments

@mreid-moz
Copy link

Issue Summary

In a stacked bar graph, the Y-axis labels do not match the actual data values, resulting in a visualization that is incorrect (too high) by an order of magnitude.

Steps to Reproduce

  1. Visit this example graph
  2. Un-select everything but the "ROW" series
  3. Observe the scale on the Y-axis compared to the hover-over value (or compare with the "table" view of the data)
  4. See that the Y-axis shows the data ~10x larger than it really is.
@rafrombrc rafrombrc added this to the 13 milestone Feb 28, 2018
@rafrombrc
Copy link
Member

Similar in some ways to #334, these should both be kept in mind when digging in to this code.

@emtwo
Copy link

emtwo commented Mar 12, 2018

Dug into this a bit and noticed that if the x-axis scale is changed from Category to Datetime this issue disappears.

@emtwo
Copy link

emtwo commented Mar 13, 2018

This issue seems to be resolved upstream. Here is an example of a simplified query that reproduces the issue:

https://sql.telemetry.mozilla.org/queries/52016#138869

Running this query:

WITH sample as (
    select '2018-02-18' as x, 'US' as type, 574047 as foo union
    select '2018-02-18' as x, 'ROW' as type, 8215767 as foo)
select * from sample

The issue is still reproducible on http://demo.redash.io but not with a fresh checkout of this repo.

@rafrombrc
Copy link
Member

Seems to be resolved by upgrading plotly dependency.

@mreid-moz
Copy link
Author

I'm still seeing this issue in the query linked in the initial summary - do you know when a fix will be deployed?

@rafrombrc
Copy link
Member

Yes, sorry... 'closed' means the fix is merged and deployed on staging, ready for confirmation (or not) by QA. We might see this pushed to prod this week, but more likely will be next week.

@mreid-moz
Copy link
Author

Cool, thanks!

@madalincm
Copy link

Verified as fixed in FF59(Win7) in stmo-stage
Postfix screencast:
347

Marking bug as verified fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants