-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using Python for the linker wrapper #49
Comments
I see that we actually do use Python to invoke But this ticket still remains: for folks using prebuilt toolchains, we could avoid requiring Python, which would be pleasant. |
FWIW, my team is still using older toolchains to support 32-bit devices. |
A useful data point. It's possible Mozilla is -- I've moved on to other projects -- but in any case, there's no rush to remove the standalone toolchain support. |
Worth noting that we leveraged the existing linker script for #75. Luckily that shouldn't be required for ever -- newer Rust |
While poking around this project for the first time in a long time, I noticed that we require Python. I couldn't remember why, and it turns out we're only invoking Python in the linker wrapper. It seems silly to route through Python for this.
I think that when this was implemented we needed Python to invoke some Android NDK standalone packaging script, so it made some sense to use Python and not fuss with Windows batch files any more than needed. But now, it would be grand to have one fewer major dependency.
The text was updated successfully, but these errors were encountered: