Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a GitHub action which runs rust-code-analysis #1037

Open
marco-c opened this issue Apr 14, 2023 · 4 comments
Open

Create a GitHub action which runs rust-code-analysis #1037

marco-c opened this issue Apr 14, 2023 · 4 comments

Comments

@marco-c
Copy link
Collaborator

marco-c commented Apr 14, 2023

No description provided.

@jayvdb
Copy link
Contributor

jayvdb commented May 18, 2024

What would it do?

@marco-c
Copy link
Collaborator Author

marco-c commented May 18, 2024

It would run rust-code-analysis against the repo where the action is set up and provide statistics about complexity. It could also run on PRs to measure the complexity before/after a change.

@jayvdb
Copy link
Contributor

jayvdb commented May 18, 2024

Ok, but an action has some raison d'etre. Is it going to be run on PRs, and thus somehow report on the PR changes only, or are you intended for it to run on pushes to main/master and do global analysis of the repo? c.f. petrabarus/github-action-committer-coverage-stats#2

And currently RCA seems to be a lot of detail, but nothing comprehensible/actionable to a human. I created #1090 because I think that could make this tool usable to a broader audience.

@marco-c
Copy link
Collaborator Author

marco-c commented May 18, 2024

Ok, but an action has some raison d'etre. Is it going to be run on PRs, and thus somehow report on the PR changes only, or are you intended for it to run on pushes to main/master and do global analysis of the repo? c.f. petrabarus/github-action-committer-coverage-stats#2

Yes, that's what I was trying to suggest in my comment.

And currently RCA seems to be a lot of detail, but nothing comprehensible/actionable to a human. I created #1090 because I think that could make this tool usable to a broader audience.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants