Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tree-sitter-ccomment tests #564

Open
Luni-4 opened this issue Mar 19, 2021 · 3 comments
Open

Add tree-sitter-ccomment tests #564

Luni-4 opened this issue Mar 19, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@Luni-4
Copy link
Collaborator

Luni-4 commented Mar 19, 2021 •
edited
Loading

It would be helpful to add tree-sitter-ccomment grammar tests. A possibile test structure could be the following one (v0.19 #552):

  1. Find a not-too-big C/C++ project easy to compile
  2. Remove comments
  3. Compile again

A unit test would be preferred.
@Luni-4 Luni-4 added the enhancement New feature or request label Mar 19, 2021
@marco-c
Copy link
Collaborator

marco-c commented Mar 19, 2021

A unit test would be preferred.

It'd be nice to have both some unit tests, and an integration test like what you described.

@Luni-4
Copy link
Collaborator Author

Luni-4 commented Jan 13, 2023

No more necessary since this grammar is only used by an external program

@Luni-4 Luni-4 closed this as completed Jan 13, 2023
@marco-c
Copy link
Collaborator

marco-c commented Jan 13, 2023

We still need tests to make sure that we don't regress the functionality that users depend on.

@marco-c marco-c reopened this Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marco-c @Luni-4