Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection API: getComposedRanges #1055

Closed
dizhang168 opened this issue Jul 26, 2024 · 1 comment
Closed

Selection API: getComposedRanges #1055

dizhang168 opened this issue Jul 26, 2024 · 1 comment

Comments

@dizhang168
Copy link

dizhang168 commented Jul 26, 2024

Request for Mozilla Position on an Emerging Web Specification

Other information

Current getComposedRanges API has single shadowRoots parameter which is a rest parameter. We propose changing it to a dictionary that contains an array of shadow roots to be consistent with other shadow DOM API:

We would also like to add selectionRoot. This argument "scopes" the selection, so that the returned selection endpoints are always descendants of element.

Proposed change:

sequence<StaticRange> getComposedRanges(optional GetComposedRangesOptions options = {});

dictionary GetComposedRangesOptions {
  sequence<ShadowRoot> shadowRoots = [];
  Node? selectionRoot = null;
};

Further, we need to re-evaluate API changes for the Range and StaticRange interface, to support nodes in different tree. Either we need to update existing definitions or we might need to add new interfaces. Help us resolve these discussions.

See:
Changes to Range, StaticRange: w3c/selection-api#169
Change getComposedRanges’ parameter to a dictionary: w3c/selection-api#176
Change getComposedRanges to have selectionRoot parameter: w3c/selection-api#180
Main: w3c/selection-api#161

@dizhang168 dizhang168 changed the title Change Selection getComposedRanges's shadowRoots parameter from rest parameter to a dictionary Selection API: getComposedRanges Aug 2, 2024
@sefeng211
Copy link
Member

We are positive with the API. The parameter changes were talked in TPAC 2024 and it was positive from the Working Group. We still have some discussions about whether we should use Composed Tree or Flat Tree for the Selection API, though I don't think they'll necessarily to impact the shape of getComposedRanges. So we are good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs proposed position
Development

No branches or pull requests

3 participants