-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zendesk Voice amendments #316
Conversation
…ent. Added GetAuditsNextPage method to tickets.cs allowing to request information for tickets having more than 100 audits.
…perty to nullable DateTimeOffset
… ticket comments.
…esk. Added Current Queue Activity class and methods
This PR looks good to me. You just need to make the build work, and I will pull these changes in |
Hi Elizabeth. Thanks for comment. I don't quite understand why the build fails. A full rebuild of the solution succeeds and I don't understand why build here on github would fail. I also cannot see any details of the failure. Do you mind pointing me in the right direction please? |
Another question whilst here if you don't mind please. Every time I create a pull request it tries to merge all my previous contributions as well. Is that normal? I've only made a single commit since my last approved pull request. I'm sure I'm doing something wrong with github but not quite sure what :( Thanks |
Ok, I think I know what happened. I haven't had a merge from master for a while so my branch has been out of date all this time. I've now merged all changes from master branch and will try to fix the build |
Ok, all of my code is now building and running correctly. For some reason there are 19 tests (Not a single one written or touched by me) Which are failing. Now I'm wondering how have they ever been checked in? |
* Added Data Class allowing to pull out voice data with Ticket Audit Event. Added GetAuditsNextPage method to tickets.cs allowing to request information for tickets having more than 100 audits. * [DEV] Added option to export Voice Agent Activity from zendesk. * [DEV] Added methtod for Historical Queue Activities * [FIX] Fixed Historical Queue Activity Test. Changed LastUpdatedAt property to nullable DateTimeOffset * Added support for submitting and reading HTML Comments in tickets * Fixed Voice, Ticket and Request Tests. Added support for HtmlBody for ticket comments. * Update TicketTests.cs * Deleted Historical Queue Activity as it's no longer supported by Zendesk. Added Current Queue Activity class and methods * Fixed build by using ZendeskApi_v2.csproj file from master branch
Deleted Historical Queue Activity as it's no longer supported by Zendesk. Added Current Queue Activity class and methods