Add locale to categories #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mozts2005
requested changes
Jun 8, 2018
| @@ -30,6 +30,10 @@ public class Categories : Core, ICategories | |||
| { | |||
| private string Locale { get; set; } | |||
|
|
|||
| private string CategoriesPath => string.IsNullOrEmpty(Locale) | |||
There was a problem hiding this comment.
What about when the Locale is set to whitespace?
Maybe we should change this to be
string.IsNullOrWhitespace()There was a problem hiding this comment.
Agree, done!
Thanks :)
|
I added more locale based stuff and rework what I did before. |
abc516
pushed a commit
to abc516/ZendeskApi_v2
that referenced
this pull request
Oct 30, 2019
* Add locale to categories * Change check for localization been added * Add more locale based stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow API download content of the categories in locale if specified.