Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #330 + CRUD operations for Comments #344

Merged
merged 4 commits into from
Jun 22, 2018
Merged

Issue #330 + CRUD operations for Comments #344

merged 4 commits into from
Jun 22, 2018

Conversation

rwjdk
Copy link

@rwjdk rwjdk commented Jun 22, 2018

Rasmus Wulff Jensen and others added 4 commits June 21, 2018 22:51
@rwjdk
Copy link
Author

rwjdk commented Jun 22, 2018

Still learning Git (day to day I'm using TFS) and this whole Pull Request thing so sorry if this was done incorrectly (Looks like previous merge is also in this pull request :-( )

@AppVeyorBot
Copy link

@mozts2005
Copy link
Member

CodeFactor found an issue: The code must not contain multiple blank lines in a row.

It's currently on:
src\ZendeskApi_v2\Requests\HelpCenter\Comments.cs:36
Commit 4acdeec

@mozts2005
Copy link
Member

CodeFactor found an issue: A C# document may only contain a single class at the root level unless all of the classes are partial and are of the same type.

It's currently on:
test\ZendeskApi_v2.Test\Settings.cs:15
Commit df03768

[OneTimeSetUp]
public void OneTimeSetUp()
{
DeleteAllArticlesFromTestSection(); //Get rid of all articles in the test-section (there should be none but there could be if previous tests have failed)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test cleanup.

Copy link
Member

@mozts2005 mozts2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

public class InitializeTests
{
[OneTimeSetUp]
public void OneTimeSetUp()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this.

@mozts2005 mozts2005 merged commit 672ed15 into Speedygeek:master Jun 22, 2018
@mozts2005
Copy link
Member

Love the work thanks for so it.

@mozts2005 mozts2005 added this to the 3.9.0 milestone Jun 23, 2018
abc516 pushed a commit to abc516/ZendeskApi_v2 that referenced this pull request Oct 30, 2019
* Test "CanCreateTicketWithDueDate" can't run on PCs that use dd/MM/yyyy as time format

* Added Code to make tests work

* - Added support for issue Speedygeek#330
- Added support for CRUD operations of Comments on Articles and Posts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants