Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCC<=4.9: Exceptions #76

Merged
merged 1 commit into from
Aug 17, 2021
Merged

GCC<=4.9: Exceptions #76

merged 1 commit into from
Aug 17, 2021

Conversation

ax3l
Copy link
Contributor

@ax3l ax3l commented Oct 29, 2020 •
edited
Loading

GCC 4.8 and 4.9 support exceptions, but are not detected as such.
This adds exception support for those compilers.

Detection taken from nlohmann/json:

__EXCEPTIONS

    This macro is defined, with value 1, when compiling a C++ source file with exceptions enabled. If -fno-exceptions is used when compiling the file, then this macro is not defined.

@ax3l
GCC<=4.9: Exceptions
8b25bdb 
GCC 4.8 and 4.9 support exceptions, but are not detected as such.
This adds exception support for those compilers.

Detection taken from `nlohmann/json`.
@ax3l ax3l mentioned this pull request Oct 29, 2020
Merged
@ax3l
Copy link
Contributor Author

ax3l commented Nov 24, 2020

@mpark friendly ping :)

@ax3l
Copy link
Contributor Author

ax3l commented Aug 11, 2021

@mpark friendly reminder :)

@mpark mpark merged commit 23cb94f into mpark:master Aug 17, 2021
@mpark
Copy link
Owner

mpark commented Aug 17, 2021

Sorry for the delay. Merged.

@ax3l ax3l deleted the fix-gcc49exceptions branch August 17, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ax3l @mpark