-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using urllib3 no data received. #20
Comments
Did you hardwire your overrides, or did you subclass urllib3? And did you test the alternative (normal requests)? |
Oh... it happens 3 years ago. I not even really remember anything from back then. |
I solved this in my code by switching from the urllib3-package to requests-package. But your analysis was important to understand it was not a problem of my own code. |
Python 3.6.7
urllib3 1.25.7
sseclient-py 1.7
When using with urllib3 not get my messages. looks like issue is:
sseclient/sseclient/__init__.py
Line 48 in 16a29bb
It's never get chunks of data. I track down problem to this place:
https://github.com/urllib3/urllib3/blob/93e5c6a5bb12a67a89bd8b24584d64a3102b2096/src/urllib3/response.py#L543
urllib3 waiting 65536 bytes of data and only then dispatch chunk.
After overriding:
https://github.com/urllib3/urllib3/blob/93e5c6a5bb12a67a89bd8b24584d64a3102b2096/src/urllib3/response.py#L794
and decreasing amt size, messages start arriving as expected.
The text was updated successfully, but these errors were encountered: